Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rendering "Invalid date" #606

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 5, 2024

We've got multiple issues with people complaining about "Invalid date". Often enough, that string is simply rendered because there (rightly) is no date available. Expected behaviour is to render the empty string, so this does that in a bunch of places.

We've got multiple issues with people complaining about
"Invalid date". Often enough, that string is simply rendered
because there (rightly) is no date available. Expected behaviour
is to render the empty string, so this does that in a bunch of places.
@Arnei Arnei added type:bug Something isn't working type:visual-clarity Improves UI readability labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-606

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-606

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Wrongly typed as number but is string
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/606/2024-06-05_09-06-08/ .
It might take a few minutes for it to become available.

@reiferschris
Copy link
Contributor

#548
I can confirm that this issue is fixed by this PR

#464 Also seems to be solved by this, selecting multiple events with different dates/times doesn't show invalid date anymore

@Arnei Arnei merged commit b17195c into opencast:main Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants